Apply review feedback

Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
This commit is contained in:
viown
2025-06-10 00:01:02 +03:00
parent e4fa463f59
commit 4ec1dba26f
2 changed files with 18 additions and 19 deletions
@@ -33,7 +33,7 @@ const PluginCard = ({ plugin, configurationPage }: IProps) => {
const disablePlugin = useDisablePlugin();
const uninstallPlugin = useUninstallPlugin();
const [ anchorEl, setAnchorEl ] = useState<HTMLElement | null>(null);
const [ isMenuOpen, setMenuOpen ] = useState(false);
const [ isMenuOpen, setIsMenuOpen ] = useState(false);
const [ isUninstallConfirmOpen, setIsUninstallConfirmOpen ] = useState(false);
const { api } = useApi();
@@ -54,7 +54,7 @@ const PluginCard = ({ plugin, configurationPage }: IProps) => {
version: plugin.Version
});
setAnchorEl(null);
setMenuOpen(false);
setIsMenuOpen(false);
}
}, [ plugin, enablePlugin ]);
@@ -65,7 +65,7 @@ const PluginCard = ({ plugin, configurationPage }: IProps) => {
version: plugin.Version
});
setAnchorEl(null);
setMenuOpen(false);
setIsMenuOpen(false);
}
}, [ plugin, disablePlugin ]);
@@ -76,7 +76,7 @@ const PluginCard = ({ plugin, configurationPage }: IProps) => {
const showUninstallConfirmDialog = useCallback(() => {
setIsUninstallConfirmOpen(true);
setAnchorEl(null);
setMenuOpen(false);
setIsMenuOpen(false);
}, []);
const onUninstall = useCallback(() => {
@@ -86,18 +86,18 @@ const PluginCard = ({ plugin, configurationPage }: IProps) => {
version: plugin.Version
});
setAnchorEl(null);
setMenuOpen(false);
setIsMenuOpen(false);
}
}, [ plugin, uninstallPlugin ]);
const onMenuClose = useCallback(() => {
setAnchorEl(null);
setMenuOpen(false);
setIsMenuOpen(false);
}, []);
const onActionClick = useCallback(() => {
setAnchorEl(actionRef.current);
setMenuOpen(true);
setIsMenuOpen(true);
}, []);
return (
+11 -12
View File
@@ -17,7 +17,8 @@ export const Component = () => {
const {
data: plugins,
isPending,
isError } = usePlugins();
isError
} = usePlugins();
const {
data: configurationPages,
isError: isConfigurationPagesError,
@@ -63,17 +64,15 @@ export const Component = () => {
/>
<Box>
<Grid container spacing={2} columns={{ xs: 1, sm: 4, md: 9, lg: 10 }}>
{filteredPlugins.map(plugin => {
return (
<Grid key={plugin.Id} size={{ xs: 1, sm: 2, md: 3, lg: 2 }}>
<PluginCard
plugin={plugin}
configurationPage={findBestConfigurationPage(configurationPages, plugin.Id || '')}
/>
</Grid>
);
})}
<Grid container spacing={2} columns={{ xs: 1, sm: 4, md: 9, lg: 8, xl: 10 }}>
{filteredPlugins.map(plugin => (
<Grid key={plugin.Id} size={{ xs: 1, sm: 2, md: 3, lg: 2 }}>
<PluginCard
plugin={plugin}
configurationPage={findBestConfigurationPage(configurationPages, plugin.Id || '')}
/>
</Grid>
))}
</Grid>
</Box>
</Stack>