From 4ec1dba26f45f05da028ea1e34e8af07720b9436 Mon Sep 17 00:00:00 2001 From: viown <48097677+viown@users.noreply.github.com> Date: Tue, 10 Jun 2025 00:01:02 +0300 Subject: [PATCH] Apply review feedback Co-authored-by: Bill Thornton --- .../plugins/components/PluginCard.tsx | 14 +++++------ src/apps/dashboard/routes/plugins/index.tsx | 23 +++++++++---------- 2 files changed, 18 insertions(+), 19 deletions(-) diff --git a/src/apps/dashboard/features/plugins/components/PluginCard.tsx b/src/apps/dashboard/features/plugins/components/PluginCard.tsx index d6efc1b1a..08bd40bbe 100644 --- a/src/apps/dashboard/features/plugins/components/PluginCard.tsx +++ b/src/apps/dashboard/features/plugins/components/PluginCard.tsx @@ -33,7 +33,7 @@ const PluginCard = ({ plugin, configurationPage }: IProps) => { const disablePlugin = useDisablePlugin(); const uninstallPlugin = useUninstallPlugin(); const [ anchorEl, setAnchorEl ] = useState(null); - const [ isMenuOpen, setMenuOpen ] = useState(false); + const [ isMenuOpen, setIsMenuOpen ] = useState(false); const [ isUninstallConfirmOpen, setIsUninstallConfirmOpen ] = useState(false); const { api } = useApi(); @@ -54,7 +54,7 @@ const PluginCard = ({ plugin, configurationPage }: IProps) => { version: plugin.Version }); setAnchorEl(null); - setMenuOpen(false); + setIsMenuOpen(false); } }, [ plugin, enablePlugin ]); @@ -65,7 +65,7 @@ const PluginCard = ({ plugin, configurationPage }: IProps) => { version: plugin.Version }); setAnchorEl(null); - setMenuOpen(false); + setIsMenuOpen(false); } }, [ plugin, disablePlugin ]); @@ -76,7 +76,7 @@ const PluginCard = ({ plugin, configurationPage }: IProps) => { const showUninstallConfirmDialog = useCallback(() => { setIsUninstallConfirmOpen(true); setAnchorEl(null); - setMenuOpen(false); + setIsMenuOpen(false); }, []); const onUninstall = useCallback(() => { @@ -86,18 +86,18 @@ const PluginCard = ({ plugin, configurationPage }: IProps) => { version: plugin.Version }); setAnchorEl(null); - setMenuOpen(false); + setIsMenuOpen(false); } }, [ plugin, uninstallPlugin ]); const onMenuClose = useCallback(() => { setAnchorEl(null); - setMenuOpen(false); + setIsMenuOpen(false); }, []); const onActionClick = useCallback(() => { setAnchorEl(actionRef.current); - setMenuOpen(true); + setIsMenuOpen(true); }, []); return ( diff --git a/src/apps/dashboard/routes/plugins/index.tsx b/src/apps/dashboard/routes/plugins/index.tsx index 8e21ccdd8..aacdd06ce 100644 --- a/src/apps/dashboard/routes/plugins/index.tsx +++ b/src/apps/dashboard/routes/plugins/index.tsx @@ -17,7 +17,8 @@ export const Component = () => { const { data: plugins, isPending, - isError } = usePlugins(); + isError + } = usePlugins(); const { data: configurationPages, isError: isConfigurationPagesError, @@ -63,17 +64,15 @@ export const Component = () => { /> - - {filteredPlugins.map(plugin => { - return ( - - - - ); - })} + + {filteredPlugins.map(plugin => ( + + + + ))}