wjones/jellyfin-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add FIXME to revisit show/hide button logic for tv providers

Browse Source
This commit is contained in:
Bill Thornton
2020-03-19 14:37:48 -04:00
parent c5cdea622a
commit 69a3c7cd53
2 changed files with 20 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/tvproviders/schedulesdirect.js
+10 -8
View File
@@ -264,18 +264,20 @@ define(["jQuery", "loading", "emby-checkbox", "listViewStyle", "emby-input", "em
self.init = function () {
options = options || {};
// Show cancel button by default
if (options.showCancelButton !== false) {
page.querySelector(".btnCancel").classList.remove("hide");
} else {
// Only hide the button if explicitly set to false; default to showing if undefined or null
// FIXME: rename this option to clarify logic
if (options.showCancelButton === false) {
page.querySelector(".btnCancel").classList.add("hide");
} else {
page.querySelector(".btnCancel").classList.remove("hide");
}
// Show submit button by default
if (options.showSubmitButton !== false) {
page.querySelector(".btnSubmitListings").classList.remove("hide");
} else {
// Only hide the button if explicitly set to false; default to showing if undefined or null
// FIXME: rename this option to clarify logic
if (options.showSubmitButton === false) {
page.querySelector(".btnSubmitListings").classList.add("hide");
} else {
page.querySelector(".btnSubmitListings").classList.remove("hide");
}
$(".formLogin", page).on("submit", function () {
src/components/tvproviders/xmltv.js
+10 -6
View File
@@ -163,16 +163,20 @@ define(["jQuery", "loading", "emby-checkbox", "emby-input", "listViewStyle", "pa
self.init = function () {
options = options || {};
if (false !== options.showCancelButton) {
page.querySelector(".btnCancel").classList.remove("hide");
} else {
// Only hide the button if explicitly set to false; default to showing if undefined or null
// FIXME: rename this option to clarify logic
if (options.showCancelButton === false) {
page.querySelector(".btnCancel").classList.add("hide");
} else {
page.querySelector(".btnCancel").classList.remove("hide");
}
if (false !== options.showSubmitButton) {
page.querySelector(".btnSubmitListings").classList.remove("hide");
} else {
// Only hide the button if explicitly set to false; default to showing if undefined or null
// FIXME: rename this option to clarify logic
if (options.showSubmitButton === false) {
page.querySelector(".btnSubmitListings").classList.add("hide");
} else {
page.querySelector(".btnSubmitListings").classList.remove("hide");
}
$("form", page).on("submit", function () {