Fix sonarcloud bug

2021-09-01 13:23:39 -04:00
parent 23d0281ca0
commit 5238888ecf
2 changed files with 7 additions and 5 deletions
@@ -156,9 +156,13 @@ class GroupSelectionMenu {
            } else if (id == 'leave-group') {
                apiClient.leaveSyncPlayGroup();
            } else if (id == 'settings') {
-                new SyncPlaySettingsEditor(apiClient, SyncPlay.Manager.getTimeSyncCore(), {
-                    groupInfo: groupInfo
-                });
+                new SyncPlaySettingsEditor(apiClient, SyncPlay.Manager.getTimeSyncCore(), { groupInfo: groupInfo })
+                    .embed()
+                    .catch(error => {
+                        if (error) {
+                            console.error('Error creating SyncPlay settings editor', error);
+                        }
+                    });
            }
        }).catch((error) => {
            if (error) {
@@ -37,8 +37,6 @@ class SettingsEditor {

        this.tabNames = [];
        this.tabs = {};
-
-        this.embed();
    }

    insertBefore(newNode, existingNode) {