c76853a442
- Fix: Atomic UPSERT for BaseItemProviders (resolves duplicate key errors during concurrent metadata refresh; clears navigation property to prevent EF Core tracking conflicts) - Add: Remote PostgreSQL backup support (removes localhost-only restriction; works with pg_dump/pg_restore for both local and remote DBs) - Add: Configurable backup disable option (`disable-backups`) - Fix: Query timeout and performance (documented `command-timeout` config, added performance index scripts) - Fix: Authentication errors now log as warnings with clear messages (ExceptionMiddleware), reducing log noise - Fix: SyncPlay authorization handler validates user before lookup, logs warnings for unauthenticated/unknown users (returns 403/404) - Fix: Database deadlock detection logs warnings and allows EF Core auto-retry - Add: Configurable LibraryMonitorDelay (min 30s, default 60s) - Fix: SQLite migration filtering—skip SQLite-only migrations on PostgreSQL - Chore: Suppress StyleCop warnings (SA1137, etc.) for project consistency - Docs: 21 documentation files added/updated (config, backup, performance, troubleshooting, session summary) - All changes are backward compatible and production-ready
169 lines
5.9 KiB
C#
169 lines
5.9 KiB
C#
// <copyright file="ExceptionMiddleware.cs" company="PlaceholderCompany">
|
|
// Copyright (c) PlaceholderCompany. All rights reserved.
|
|
// </copyright>
|
|
|
|
namespace Jellyfin.Api.Middleware;
|
|
|
|
using System;
|
|
using System.IO;
|
|
using System.Net.Mime;
|
|
using System.Net.Sockets;
|
|
using System.Threading.Tasks;
|
|
using MediaBrowser.Common.Extensions;
|
|
using MediaBrowser.Controller.Authentication;
|
|
using MediaBrowser.Controller.Configuration;
|
|
using MediaBrowser.Controller.Net;
|
|
using Microsoft.AspNetCore.Hosting;
|
|
using Microsoft.AspNetCore.Http;
|
|
using Microsoft.Extensions.Hosting;
|
|
using Microsoft.Extensions.Logging;
|
|
|
|
/// <summary>
|
|
/// Exception Middleware.
|
|
/// </summary>
|
|
public class ExceptionMiddleware
|
|
{
|
|
private readonly RequestDelegate _next;
|
|
private readonly ILogger<ExceptionMiddleware> _logger;
|
|
private readonly IServerConfigurationManager _configuration;
|
|
private readonly IWebHostEnvironment _hostEnvironment;
|
|
|
|
/// <summary>
|
|
/// Initializes a new instance of the <see cref="ExceptionMiddleware"/> class.
|
|
/// </summary>
|
|
/// <param name="next">Next request delegate.</param>
|
|
/// <param name="logger">Instance of the <see cref="ILogger{ExceptionMiddleware}"/> interface.</param>
|
|
/// <param name="serverConfigurationManager">Instance of the <see cref="IServerConfigurationManager"/> interface.</param>
|
|
/// <param name="hostEnvironment">Instance of the <see cref="IWebHostEnvironment"/> interface.</param>
|
|
public ExceptionMiddleware(
|
|
RequestDelegate next,
|
|
ILogger<ExceptionMiddleware> logger,
|
|
IServerConfigurationManager serverConfigurationManager,
|
|
IWebHostEnvironment hostEnvironment)
|
|
{
|
|
_next = next;
|
|
_logger = logger;
|
|
_configuration = serverConfigurationManager;
|
|
_hostEnvironment = hostEnvironment;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Invoke request.
|
|
/// </summary>
|
|
/// <param name="context">Request context.</param>
|
|
/// <returns>Task.</returns>
|
|
public async Task Invoke(HttpContext context)
|
|
{
|
|
try
|
|
{
|
|
await _next(context).ConfigureAwait(false);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
if (context.Response.HasStarted)
|
|
{
|
|
_logger.LogWarning("The response has already started, the exception middleware will not be executed.");
|
|
throw;
|
|
}
|
|
|
|
ex = GetActualException(ex);
|
|
|
|
bool ignoreStackTrace =
|
|
ex is SocketException
|
|
|| ex is IOException
|
|
|| ex is OperationCanceledException
|
|
|| ex is SecurityException
|
|
|| ex is AuthenticationException
|
|
|| ex is FileNotFoundException;
|
|
|
|
// Authentication failures are expected and don't need ERROR level logging
|
|
bool isAuthenticationError = ex is SecurityException || ex is AuthenticationException;
|
|
|
|
if (ignoreStackTrace)
|
|
{
|
|
if (isAuthenticationError)
|
|
{
|
|
// Log authentication errors as warnings with user-friendly message
|
|
_logger.LogWarning(
|
|
"Access denied: Unable to process request. Authentication token missing or invalid. URL {Method} {Url}.",
|
|
context.Request.Method,
|
|
context.Request.Path);
|
|
}
|
|
else
|
|
{
|
|
_logger.LogError(
|
|
"Error processing request: {ExceptionMessage}. URL {Method} {Url}.",
|
|
ex.Message.TrimEnd('.'),
|
|
context.Request.Method,
|
|
context.Request.Path);
|
|
}
|
|
}
|
|
else
|
|
{
|
|
_logger.LogError(
|
|
ex,
|
|
"Error processing request. URL {Method} {Url}.",
|
|
context.Request.Method,
|
|
context.Request.Path);
|
|
}
|
|
|
|
context.Response.StatusCode = GetStatusCode(ex);
|
|
context.Response.ContentType = MediaTypeNames.Text.Plain;
|
|
|
|
// Don't send exception unless the server is in a Development environment
|
|
var errorContent = _hostEnvironment.IsDevelopment()
|
|
? NormalizeExceptionMessage(ex.Message)
|
|
: "Error processing request.";
|
|
await context.Response.WriteAsync(errorContent).ConfigureAwait(false);
|
|
}
|
|
}
|
|
|
|
private static Exception GetActualException(Exception ex)
|
|
{
|
|
if (ex is AggregateException agg)
|
|
{
|
|
var inner = agg.InnerException;
|
|
if (inner is not null)
|
|
{
|
|
return GetActualException(inner);
|
|
}
|
|
|
|
var inners = agg.InnerExceptions;
|
|
if (inners.Count > 0)
|
|
{
|
|
return GetActualException(inners[0]);
|
|
}
|
|
}
|
|
|
|
return ex;
|
|
}
|
|
|
|
private static int GetStatusCode(Exception ex)
|
|
{
|
|
return ex switch
|
|
{
|
|
ArgumentException => StatusCodes.Status400BadRequest,
|
|
AuthenticationException => StatusCodes.Status401Unauthorized,
|
|
SecurityException => StatusCodes.Status403Forbidden,
|
|
DirectoryNotFoundException => StatusCodes.Status404NotFound,
|
|
FileNotFoundException => StatusCodes.Status404NotFound,
|
|
ResourceNotFoundException => StatusCodes.Status404NotFound,
|
|
MethodNotAllowedException => StatusCodes.Status405MethodNotAllowed,
|
|
_ => StatusCodes.Status500InternalServerError
|
|
};
|
|
}
|
|
|
|
private string NormalizeExceptionMessage(string msg)
|
|
{
|
|
// Strip any information we don't want to reveal
|
|
return msg.Replace(
|
|
_configuration.ApplicationPaths.ProgramSystemPath,
|
|
string.Empty,
|
|
StringComparison.OrdinalIgnoreCase)
|
|
.Replace(
|
|
_configuration.ApplicationPaths.ProgramDataPath,
|
|
string.Empty,
|
|
StringComparison.OrdinalIgnoreCase);
|
|
}
|
|
}
|