Fix 12 code analysis errors in MediaEncoding projects - use LoggerMessage source generators and specific exception types

This commit is contained in:
2026-04-29 08:24:34 -04:00
parent aead802df6
commit 786c61ba09
6 changed files with 62 additions and 14 deletions
@@ -16,7 +16,7 @@ using Microsoft.Extensions.Logging;
namespace Jellyfin.MediaEncoding.Hls.Cache;
/// <inheritdoc />
public class CacheDecorator : IKeyframeExtractor
public partial class CacheDecorator : IKeyframeExtractor
{
private readonly IKeyframeRepository _keyframeRepository;
private readonly IKeyframeExtractor _keyframeExtractor;
@@ -58,11 +58,11 @@ public class CacheDecorator : IKeyframeExtractor
{
if (!_keyframeExtractor.TryExtractKeyframes(itemId, filePath, out var result))
{
_logger.LogDebug("Failed to extract keyframes using {ExtractorName}", _keyframeExtractorName);
LogKeyframeExtractionFailed(_logger, _keyframeExtractorName);
return false;
}
_logger.LogDebug("Successfully extracted keyframes using {ExtractorName}", _keyframeExtractorName);
LogKeyframeExtractionSucceeded(_logger, _keyframeExtractorName);
keyframeData = result;
_keyframeRepository.SaveKeyframeDataAsync(itemId, keyframeData, CancellationToken.None)
.GetAwaiter()
@@ -71,4 +71,10 @@ public class CacheDecorator : IKeyframeExtractor
return true;
}
[LoggerMessage(Level = LogLevel.Debug, Message = "Failed to extract keyframes using {ExtractorName}")]
private static partial void LogKeyframeExtractionFailed(ILogger logger, string extractorName);
[LoggerMessage(Level = LogLevel.Debug, Message = "Successfully extracted keyframes using {ExtractorName}")]
private static partial void LogKeyframeExtractionSucceeded(ILogger logger, string extractorName);
}