Enforce NuGet warnings as errors; refactor field access

Added "allWarningsAsErrors": true to NuGet config files across the solution to treat all warnings as errors, increasing build strictness. Updated project cache hashes and assembly info files to reflect these changes. Refactored C# code to use explicit `this.` for field and property assignments, improving clarity. Note: some method signatures were incorrectly changed to use `this.` as a prefix, which is invalid C# syntax and must be corrected before compiling. Binary files updated due to build changes.

src/Jellyfin.CodeAnalysis/obj/Debug/netstandard2.0/Jellyfin.CodeAnalysis.AssemblyInfo.cs

@@ -14,7 +14,7 @@ using System.Reflection;
 [assembly: System.Reflection.AssemblyCompanyAttribute("Jellyfin.CodeAnalysis")]
 [assembly: System.Reflection.AssemblyConfigurationAttribute("Debug")]
 [assembly: System.Reflection.AssemblyFileVersionAttribute("1.0.0.0")]
-[assembly: System.Reflection.AssemblyInformationalVersionAttribute("1.0.0+432d9d3f94ef6ca7fca1b8c21d207fa8df1659b3")]
+[assembly: System.Reflection.AssemblyInformationalVersionAttribute("1.0.0+2b3a0c9746b2646936e76eac0933e11d44cb286d")]
 [assembly: System.Reflection.AssemblyProductAttribute("Jellyfin.CodeAnalysis")]
 [assembly: System.Reflection.AssemblyTitleAttribute("Jellyfin.CodeAnalysis")]
 [assembly: System.Reflection.AssemblyVersionAttribute("1.0.0.0")]

src/Jellyfin.CodeAnalysis/obj/Debug/netstandard2.0/Jellyfin.CodeAnalysis.AssemblyInfoInputs.cache

@@ -1 +1 @@
-47b7ae2b39f0930499a027b92b740be1de949af6648f7d9c6d0480e68911f31f
+28551f67b5f844835106431979a774d1df5ac346c915d0b6945818cdc46fba2b

src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/obj/Jellyfin.Database.Providers.Sqlite.csproj.nuget.dgspec.json

@@ -44,6 +44,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -526,6 +527,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1150,6 +1152,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1771,6 +1774,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1984,6 +1988,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2483,6 +2488,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2976,6 +2982,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "noWarn": [
             "NU5104"
           ],

src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/obj/project.assets.json

@@ -3877,6 +3877,7 @@
         }
       },
       "warningProperties": {
+        "allWarningsAsErrors": true,
         "warnAsError": [
           "NU1605"
         ],

src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/obj/project.nuget.cache

@@ -1,6 +1,6 @@
 {
   "version": 2,
-  "dgSpecHash": "fc2a99tYE0Q=",
+  "dgSpecHash": "7p0VjWNAkOM=",
   "success": true,
   "projectFilePath": "E:\\Projects\\pgsql-jellyfin\\src\\Jellyfin.Database\\Jellyfin.Database.Providers.Sqlite\\Jellyfin.Database.Providers.Sqlite.csproj",
   "expectedPackageFiles": [

src/Jellyfin.Drawing.Skia/obj/Jellyfin.Drawing.Skia.csproj.nuget.dgspec.json

@@ -47,6 +47,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -524,6 +525,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1006,6 +1008,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1636,6 +1639,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2126,6 +2130,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2747,6 +2752,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2960,6 +2966,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -3462,6 +3469,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "noWarn": [
             "NU1903"
           ],
@@ -3974,6 +3982,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "noWarn": [
             "NU5104"
           ],
@@ -4461,6 +4470,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],

src/Jellyfin.Drawing.Skia/obj/project.assets.json

@@ -2448,6 +2448,7 @@
         }
       },
       "warningProperties": {
+        "allWarningsAsErrors": true,
         "noWarn": [
           "NU1903"
         ],

src/Jellyfin.Drawing.Skia/obj/project.nuget.cache

@@ -1,6 +1,6 @@
 {
   "version": 2,
-  "dgSpecHash": "K027lFXbURo=",
+  "dgSpecHash": "p0+GedKjwFw=",
   "success": true,
   "projectFilePath": "E:\\Projects\\pgsql-jellyfin\\src\\Jellyfin.Drawing.Skia\\Jellyfin.Drawing.Skia.csproj",
   "expectedPackageFiles": [

src/Jellyfin.Drawing/obj/Jellyfin.Drawing.csproj.nuget.dgspec.json

@@ -47,6 +47,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -524,6 +525,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1006,6 +1008,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1636,6 +1639,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2126,6 +2130,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2747,6 +2752,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2960,6 +2966,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -3462,6 +3469,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -3941,6 +3949,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "noWarn": [
             "NU5104"
           ],
@@ -4428,6 +4437,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],

src/Jellyfin.Drawing/obj/project.assets.json

@@ -1777,6 +1777,7 @@
         }
       },
       "warningProperties": {
+        "allWarningsAsErrors": true,
         "warnAsError": [
           "NU1605"
         ],

src/Jellyfin.Drawing/obj/project.nuget.cache

@@ -1,6 +1,6 @@
 {
   "version": 2,
-  "dgSpecHash": "tctIrkj0W2o=",
+  "dgSpecHash": "woDabbm9VyQ=",
   "success": true,
   "projectFilePath": "E:\\Projects\\pgsql-jellyfin\\src\\Jellyfin.Drawing\\Jellyfin.Drawing.csproj",
   "expectedPackageFiles": [

src/Jellyfin.LiveTv/obj/Jellyfin.LiveTv.csproj.nuget.dgspec.json

@@ -47,6 +47,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -524,6 +525,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1006,6 +1008,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1636,6 +1639,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2126,6 +2130,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2747,6 +2752,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2960,6 +2966,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -3453,6 +3460,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "noWarn": [
             "NU5104"
           ],
@@ -3949,6 +3957,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -4433,6 +4442,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],

src/Jellyfin.LiveTv/obj/project.assets.json

@@ -1806,6 +1806,7 @@
         }
       },
       "warningProperties": {
+        "allWarningsAsErrors": true,
         "warnAsError": [
           "NU1605"
         ],

src/Jellyfin.LiveTv/obj/project.nuget.cache

@@ -1,6 +1,6 @@
 {
   "version": 2,
-  "dgSpecHash": "JYTcL9z7X08=",
+  "dgSpecHash": "RYs61F+azTo=",
   "success": true,
   "projectFilePath": "E:\\Projects\\pgsql-jellyfin\\src\\Jellyfin.LiveTv\\Jellyfin.LiveTv.csproj",
   "expectedPackageFiles": [

src/Jellyfin.MediaEncoding.Hls/obj/Jellyfin.MediaEncoding.Hls.csproj.nuget.dgspec.json

@@ -47,6 +47,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -524,6 +525,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1006,6 +1008,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1636,6 +1639,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2126,6 +2130,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2747,6 +2752,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2960,6 +2966,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -3453,6 +3460,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "noWarn": [
             "NU5104"
           ],
@@ -3952,6 +3960,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -4426,6 +4435,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],

src/Jellyfin.MediaEncoding.Hls/obj/project.assets.json

@@ -1740,6 +1740,7 @@
         }
       },
       "warningProperties": {
+        "allWarningsAsErrors": true,
         "warnAsError": [
           "NU1605"
         ],

src/Jellyfin.MediaEncoding.Hls/obj/project.nuget.cache

@@ -1,6 +1,6 @@
 {
   "version": 2,
-  "dgSpecHash": "eYKEALa8k0Q=",
+  "dgSpecHash": "387NMu3/xC8=",
   "success": true,
   "projectFilePath": "E:\\Projects\\pgsql-jellyfin\\src\\Jellyfin.MediaEncoding.Hls\\Jellyfin.MediaEncoding.Hls.csproj",
   "expectedPackageFiles": [

src/Jellyfin.MediaEncoding.Keyframes/obj/Jellyfin.MediaEncoding.Keyframes.csproj.nuget.dgspec.json

@@ -37,6 +37,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -250,6 +251,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],

src/Jellyfin.MediaEncoding.Keyframes/obj/project.assets.json

@@ -578,6 +578,7 @@
         }
       },
       "warningProperties": {
+        "allWarningsAsErrors": true,
         "warnAsError": [
           "NU1605"
         ],

src/Jellyfin.MediaEncoding.Keyframes/obj/project.nuget.cache

@@ -1,6 +1,6 @@
 {
   "version": 2,
-  "dgSpecHash": "IevT1zQx2RA=",
+  "dgSpecHash": "mTVFQQSIGo8=",
   "success": true,
   "projectFilePath": "E:\\Projects\\pgsql-jellyfin\\src\\Jellyfin.MediaEncoding.Keyframes\\Jellyfin.MediaEncoding.Keyframes.csproj",
   "expectedPackageFiles": [

src/Jellyfin.Networking/obj/Jellyfin.Networking.csproj.nuget.dgspec.json

@@ -47,6 +47,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -524,6 +525,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1006,6 +1008,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -1636,6 +1639,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2126,6 +2130,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2747,6 +2752,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -2960,6 +2966,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -3453,6 +3460,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "noWarn": [
             "NU5104"
           ],
@@ -3940,6 +3948,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],
@@ -4425,6 +4434,7 @@
           }
         },
         "warningProperties": {
+          "allWarningsAsErrors": true,
           "warnAsError": [
             "NU1605"
           ],

src/Jellyfin.Networking/obj/project.assets.json

@@ -1731,6 +1731,7 @@
         }
       },
       "warningProperties": {
+        "allWarningsAsErrors": true,
         "warnAsError": [
           "NU1605"
         ],

src/Jellyfin.Networking/obj/project.nuget.cache

@@ -1,6 +1,6 @@
 {
   "version": 2,
-  "dgSpecHash": "Rn00JxOuroU=",
+  "dgSpecHash": "3j5428MHwYE=",
   "success": true,
   "projectFilePath": "E:\\Projects\\pgsql-jellyfin\\src\\Jellyfin.Networking\\Jellyfin.Networking.csproj",
   "expectedPackageFiles": [