Enforce NuGet warnings as errors; refactor field access

Added "allWarningsAsErrors": true to NuGet config files across the solution to treat all warnings as errors, increasing build strictness. Updated project cache hashes and assembly info files to reflect these changes. Refactored C# code to use explicit `this.` for field and property assignments, improving clarity. Note: some method signatures were incorrectly changed to use `this.` as a prefix, which is invalid C# syntax and must be corrected before compiling. Binary files updated due to build changes.
2026-02-21 11:07:54 -05:00
parent 2b3a0c9746
commit 477045704e
141 changed files with 714 additions and 291 deletions
@@ -47,6 +47,7 @@
          }
        },
        "warningProperties": {
+          "allWarningsAsErrors": true,
          "warnAsError": [
            "NU1605"
          ],
@@ -524,6 +525,7 @@
          }
        },
        "warningProperties": {
+          "allWarningsAsErrors": true,
          "warnAsError": [
            "NU1605"
          ],
@@ -1018,6 +1020,7 @@
          }
        },
        "warningProperties": {
+          "allWarningsAsErrors": true,
          "warnAsError": [
            "NU1605"
          ],
@@ -1505,6 +1508,7 @@
          }
        },
        "warningProperties": {
+          "allWarningsAsErrors": true,
          "warnAsError": [
            "NU1605"
          ],
@@ -2135,6 +2139,7 @@
          }
        },
        "warningProperties": {
+          "allWarningsAsErrors": true,
          "warnAsError": [
            "NU1605"
          ],
@@ -2625,6 +2630,7 @@
          }
        },
        "warningProperties": {
+          "allWarningsAsErrors": true,
          "warnAsError": [
            "NU1605"
          ],
@@ -3246,6 +3252,7 @@
          }
        },
        "warningProperties": {
+          "allWarningsAsErrors": true,
          "warnAsError": [
            "NU1605"
          ],
@@ -3459,6 +3466,7 @@
          }
        },
        "warningProperties": {
+          "allWarningsAsErrors": true,
          "warnAsError": [
            "NU1605"
          ],
@@ -3958,6 +3966,7 @@
          }
        },
        "warningProperties": {
+          "allWarningsAsErrors": true,
          "warnAsError": [
            "NU1605"
          ],
@@ -4451,6 +4460,7 @@
          }
        },
        "warningProperties": {
+          "allWarningsAsErrors": true,
          "noWarn": [
            "NU5104"
          ],
@@ -4938,6 +4948,7 @@
          }
        },
        "warningProperties": {
+          "allWarningsAsErrors": true,
          "warnAsError": [
            "NU1605"
          ],
@@ -2241,6 +2241,7 @@
        }
      },
      "warningProperties": {
+        "allWarningsAsErrors": true,
        "warnAsError": [
          "NU1605"
        ],
@@ -1,6 +1,6 @@
 {
  "version": 2,
-  "dgSpecHash": "uLEFI7ariss=",
+  "dgSpecHash": "S+jrIut2wYc=",
  "success": true,
  "projectFilePath": "E:\\Projects\\pgsql-jellyfin\\Jellyfin.Server.Implementations\\Jellyfin.Server.Implementations.csproj",
  "expectedPackageFiles": [