Merge pull request #5734 from prsantos-com/sonarcloud-promise-rejection

Use Error instead of literal for promise rejection

src/components/actionSheet/actionSheet.ts

@@ -366,7 +366,7 @@ export function show(options: Options) {
 
                     resolve(selectedId);
                 } else {
-                    reject('ActionSheet closed without resolving');
+                    reject(new Error('ActionSheet closed without resolving'));
                 }
             }
         });

src/components/playback/playbackmanager.js

@@ -2502,7 +2502,7 @@ class PlaybackManager {
             return Promise.resolve()
                 .then(() => {
                     if (!isServerItem(item) || itemHelper.isLocalItem(item)) {
-                        return Promise.reject('skip bitrate detection');
+                        return Promise.reject(new Error('skip bitrate detection'));
                     }
 
                     return apiClient.getEndpointInfo()
@@ -2514,7 +2514,7 @@ class PlaybackManager {
                                 });
                             }
 
-                            return Promise.reject('skip bitrate detection');
+                            return Promise.reject(new Error('skip bitrate detection'));
                         });
                 })
                 .catch(() => getSavedMaxStreamingBitrate(apiClient, mediaType));

src/components/router/appRouter.js

@@ -389,7 +389,7 @@ class AppRouter {
             if (firstResult.State === ConnectionState.ServerSignIn) {
                 const url = firstResult.ApiClient.serverAddress() + '/System/Info/Public';
                 fetch(url).then(response => {
-                    if (!response.ok) return Promise.reject('fetch failed');
+                    if (!response.ok) return Promise.reject(new Error('fetch failed'));
                     return response.json();
                 }).then(data => {
                     if (data !== null && data.StartupWizardCompleted === false) {