fix: limit secondary to non-SSA/ASS subtitles

2022-10-10 21:26:15 -04:00
parent f33699ad8a
commit 9ddafb063b
3 changed files with 22 additions and 8 deletions
@@ -478,9 +478,10 @@ function tryRemoveElement(elem) {
                const initialSubtitleStream = options.mediaSource.MediaStreams[this.#subtitleTrackIndexToSetOnPlaying];
                if (!initialSubtitleStream || initialSubtitleStream.DeliveryMethod === 'Encode') {
                    this.#subtitleTrackIndexToSetOnPlaying = -1;
+                    secondaryTrackValid = false;
                }
-                // secondary track should not be shown if primary track is no longer `External` or is not on
-                if (initialSubtitleStream && initialSubtitleStream.DeliveryMethod !== 'External') {
+                // secondary track should not be shown if primary track is no longer a valid pair
+                if (initialSubtitleStream && !playbackManager.trackHasSecondarySubtitleSupport(initialSubtitleStream)) {
                    secondaryTrackValid = false;
                }
            } else {