From eed2084584b37a0f0378a2c69f9650275177722e Mon Sep 17 00:00:00 2001 From: anantharaju Date: Mon, 3 Apr 2023 10:43:19 +0530 Subject: [PATCH 1/3] Remove this commented out code --- CONTRIBUTORS.md | 1 + src/components/dialogHelper/dialogHelper.js | 1 - src/components/filtermenu/filtermenu.js | 2 -- src/components/htmlMediaHelper.js | 6 +----- src/components/multiSelect/multiSelect.js | 8 +------- src/components/playback/playbackmanager.js | 1 - src/libraries/scroller.js | 4 +--- 7 files changed, 4 insertions(+), 19 deletions(-) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index f3dbfec6d..06659768a 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -60,6 +60,7 @@ - [edvwib](https://github.com/edvwib) - [Rob Farraher](https://github.com/farraherbg) - [Pier-Luc Ducharme](https://github.com/pl-ducharme) + - [Anantharaju S](https://github.com/Anantharajus) # Emby Contributors diff --git a/src/components/dialogHelper/dialogHelper.js b/src/components/dialogHelper/dialogHelper.js index 681152546..32fa10504 100644 --- a/src/components/dialogHelper/dialogHelper.js +++ b/src/components/dialogHelper/dialogHelper.js @@ -250,7 +250,6 @@ import '../../styles/scrollstyles.scss'; } function isOpened(dlg) { - //return dlg.opened; return !dlg.classList.contains('hide'); } diff --git a/src/components/filtermenu/filtermenu.js b/src/components/filtermenu/filtermenu.js index 4c1b6d625..d7e9c8765 100644 --- a/src/components/filtermenu/filtermenu.js +++ b/src/components/filtermenu/filtermenu.js @@ -297,10 +297,8 @@ class FilterMenu { } if (submitted) { - //if (!options.onChange) { saveValues(dlg, options.settings, options.settingsKey, options.setfilters); return resolve(); - //} } return resolve(); }); diff --git a/src/components/htmlMediaHelper.js b/src/components/htmlMediaHelper.js index 22816aee3..149d9ef5c 100644 --- a/src/components/htmlMediaHelper.js +++ b/src/components/htmlMediaHelper.js @@ -52,17 +52,13 @@ import Events from '../utils/events.ts'; } if (browser.edge && mediaType === 'Video') { - //return true; + } // simple playback should use the native support if (runTimeTicks) { - //if (!browser.edge) { return false; - //} } - - //return false; } return true; diff --git a/src/components/multiSelect/multiSelect.js b/src/components/multiSelect/multiSelect.js index 398496817..681dab1fc 100644 --- a/src/components/multiSelect/multiSelect.js +++ b/src/components/multiSelect/multiSelect.js @@ -205,13 +205,7 @@ import datetime from '../../scripts/datetime'; if (user.Policy.EnableContentDownloading && appHost.supports('filedownload')) { // Disabled because there is no callback for this item - /* - menuItems.push({ - name: globalize.translate('Download'), - id: 'download', - icon: 'file_download' - }); - */ + } if (user.Policy.IsAdministrator) { diff --git a/src/components/playback/playbackmanager.js b/src/components/playback/playbackmanager.js index 31b04e0fb..00030e321 100644 --- a/src/components/playback/playbackmanager.js +++ b/src/components/playback/playbackmanager.js @@ -1038,7 +1038,6 @@ class PlaybackManager { } } - //var mediaType = item.MediaType; return getPlayer(item, getDefaultPlayOptions()) != null; }; diff --git a/src/libraries/scroller.js b/src/libraries/scroller.js index 670a46f4b..528741b4f 100644 --- a/src/libraries/scroller.js +++ b/src/libraries/scroller.js @@ -509,8 +509,6 @@ const scrollerFactory = function (frame, options) { } } - //event.preventDefault(); - // Disable click on a source element, as it is unwelcome when dragging if (!dragging.locked && dragging.path > dragging.pathToLock) { dragging.locked = 1; @@ -606,7 +604,7 @@ const scrollerFactory = function (frame, options) { if (transform) { // Trap scrolling only when necessary and/or requested if (delta > 0 && pos.dest < pos.end || delta < 0 && pos.dest > pos.start) { - //stopDefault(event, 1); + } self.slideBy(o.scrollBy * delta); From e49274161887d54def860955f1c9f1678514afbd Mon Sep 17 00:00:00 2001 From: Anantharaju S Date: Thu, 13 Apr 2023 04:55:17 +0530 Subject: [PATCH 2/3] Update src/components/multiSelect/multiSelect.js Co-authored-by: Bill Thornton --- src/components/multiSelect/multiSelect.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/multiSelect/multiSelect.js b/src/components/multiSelect/multiSelect.js index 681dab1fc..c361c182f 100644 --- a/src/components/multiSelect/multiSelect.js +++ b/src/components/multiSelect/multiSelect.js @@ -205,7 +205,6 @@ import datetime from '../../scripts/datetime'; if (user.Policy.EnableContentDownloading && appHost.supports('filedownload')) { // Disabled because there is no callback for this item - } if (user.Policy.IsAdministrator) { From 5df9fa80876b0f31fb4bfd1548dace72f65f5161 Mon Sep 17 00:00:00 2001 From: anantharaju Date: Thu, 13 Apr 2023 05:10:42 +0530 Subject: [PATCH 3/3] Fixing linting errors --- src/components/htmlMediaHelper.js | 4 ---- src/libraries/scroller.js | 5 ----- 2 files changed, 9 deletions(-) diff --git a/src/components/htmlMediaHelper.js b/src/components/htmlMediaHelper.js index 149d9ef5c..92fb4d013 100644 --- a/src/components/htmlMediaHelper.js +++ b/src/components/htmlMediaHelper.js @@ -51,10 +51,6 @@ import Events from '../utils/events.ts'; return true; } - if (browser.edge && mediaType === 'Video') { - - } - // simple playback should use the native support if (runTimeTicks) { return false; diff --git a/src/libraries/scroller.js b/src/libraries/scroller.js index 528741b4f..abfa30cdf 100644 --- a/src/libraries/scroller.js +++ b/src/libraries/scroller.js @@ -602,11 +602,6 @@ const scrollerFactory = function (frame, options) { let delta = normalizeWheelDelta(event); if (transform) { - // Trap scrolling only when necessary and/or requested - if (delta > 0 && pos.dest < pos.end || delta < 0 && pos.dest > pos.start) { - - } - self.slideBy(o.scrollBy * delta); } else { if (isSmoothScrollSupported) {