Fix sonarjs no-collapsible-if

2022-10-03 14:22:02 -04:00
parent ccdbf0bfc3
commit 1f4e65822b
33 changed files with 330 additions and 473 deletions
@@ -46,11 +46,9 @@ function getImageUrl(item, options, apiClient) {
        return apiClient.getScaledImageUrl(item.Id, options);
    }

-    if (options.type === 'Primary') {
-        if (item.AlbumId && item.AlbumPrimaryImageTag) {
-            options.tag = item.AlbumPrimaryImageTag;
-            return apiClient.getScaledImageUrl(item.AlbumId, options);
-        }
+    if (options.type === 'Primary' && item.AlbumId && item.AlbumPrimaryImageTag) {
+        options.tag = item.AlbumPrimaryImageTag;
+        return apiClient.getScaledImageUrl(item.AlbumId, options);
    }

    return null;