From 0e447a6eb4d9dacf64a3257fcd2c328b62049c39 Mon Sep 17 00:00:00 2001 From: Bradley Eaton Date: Sun, 27 Jul 2025 11:19:16 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com> --- src/scripts/gamepadtokey.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/scripts/gamepadtokey.js b/src/scripts/gamepadtokey.js index 9bb1f023d..26346a513 100644 --- a/src/scripts/gamepadtokey.js +++ b/src/scripts/gamepadtokey.js @@ -81,11 +81,11 @@ _ButtonPressedState.setgamepadA = function (newPressedState) { const newPressedEvent = raiseKeyEvent(_gamepadAPressed, newPressedState, _GAMEPAD_A_KEY, _GAMEPAD_A_KEYCODE, false, true, _gamepadADownEvent); _gamepadAPressed = newPressedState; - if (newPressedState && newPressedEvent != null) { - _gamepadADownEvent = newPressedEvent; - } else if (!newPressedState) { + if (!newPressedState) { // reset on keyup _gamepadADownEvent = null; + } else if (newPressedEvent != null) { + _gamepadADownEvent = newPressedEvent; } }; @@ -202,6 +202,7 @@ function raiseEvent(name, key, keyCode) { event.key = key; event.keyCode = keyCode; (document.activeElement || document.body).dispatchEvent(event); + return event; } @@ -243,6 +244,7 @@ function raiseKeyEvent(oldPressedState, newPressedState, key, keyCode, enableRep clickElement(document.activeElement || window); } } + return newPressedEvent; }